Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ffmpeg] add implicit link libs (#42676) #42677

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[ffmpeg] add implicit link libs (#42676) #42677

merged 1 commit into from
Dec 19, 2024

Conversation

wikiwang1991
Copy link
Contributor

@wikiwang1991 wikiwang1991 commented Dec 13, 2024 •
edited
Loading

Fixes #42676.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL
Copy link
Contributor

Please complete the checklist of this PR, I have updated #42677 (comment).

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Dec 13, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Dec 13, 2024

Please complete the checklist of this PR

Most of the checklist is not relevant here. But you have to deal with incrementing the port-version in ports/ffmpeg/vcpkg.json, commit this change, then run vcpkg x-add-version ffmpeg, and commit this change, too.

@wikiwang1991
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Molok"

@wikiwang1991 wikiwang1991 marked this pull request as draft December 17, 2024 01:54
@wikiwang1991 wikiwang1991 marked this pull request as ready for review December 17, 2024 01:56
@wikiwang1991
Copy link
Contributor Author

@LilyWangLL 老铁合一下

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 18, 2024
@JavierMatosD JavierMatosD merged commit 5a1b13c into microsoft:master Dec 19, 2024
17 checks passed
@wikiwang1991 wikiwang1991 deleted the fix_ffmpeg branch December 20, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ffmpeg] build failure using x64-windows-static
4 participants
@wikiwang1991 @LilyWangLL @dg0yt @JavierMatosD